-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for IAMbic template examples with IAMOps flow #420
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
- Coverage 85.21% 85.19% -0.02%
==========================================
Files 98 98
Lines 10721 10721
==========================================
- Hits 9136 9134 -2
- Misses 1585 1587 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
└── development | ||
``` | ||
|
||
## IAMOps Flow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might make a mention that this IAMOps Flow is for github App integrated Repos. -- then link to that Quick Start Guide
Also mention the actions templates that are being used and that they will consume action minutes for each run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I revised these docs pretty significantly and moved the detailed sections to the IAMOps Philosophy section. Also added a reference to the minutes consumption in the GitHub docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 1 minor syntax suggestion
docs/web/docs/01-overview.mdx
Outdated
@@ -6,10 +6,13 @@ title: Overview | |||
## What is IAMbic? | |||
|
|||
IAMbic tackles the complex task of managing distributed permissions across multiple cloud environments, such as AWS, Azure Active Directory, | |||
Okta, and Google Workspace. IAMbic creates a comprehensive copy of your human and cloud principals, and permissions in human readable | |||
Okta, and Google Workspace. IAMbic creates a comprehensive copy of your human and cloud principals, and permissions as human readable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "in a human readable format"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds documentation for the IAMbic templates repository. It also adds tomlkit, which is a dependency needed for our build script.